gbulmer
Moderator
For giggles, I ran splint across maplelib.
You might be interested to do the same, just to see the code with 'fresh eyes'.
Sadly splint doesn't seem to handle asm properly :-(
There are a couple of things you might want to think about; nothing to worry about, everything I saw were only warnings and appeared to be okay. One thing I'd comment on is using 1UL to get an unsigned 32 bit value. I think both 1U and (unit32)1 work okay and are a bit clearer (to me, anyway).
poslathian
LeafLabs
well take a look, thanks!
We have definitely had bugs before caused by things like:
#define MY_REG_VALUE 0x12345678
which should have been
#define MY_REG_VALUE (uint32)(0x12345678)
or using UL notation. Well talk about adding something about this to any coding standards.
Personally, I wanted to follow the ST convention of having all the types be as:
u32, u16, s16, vu8, etc - oh well.
gbulmer
Moderator
Well, I thought uint8, uint16, uint32, etc. were inspired; they get everyone ready for the transition to Go lang ;-)
What is s16 and vu8?
When faced with the choice between uint32, u32, uint32_t, and int16, int16_t, i16, ... I'm okay with uint32, int16, etc. Most people recognise them quickly, and it's two characters shorter than the _t versions!
You must log in to post.