http://forums.leaflabs.com/topic.php?id=252 A place to share, learn, and grow... en-US Fri, 22 Jan 2016 00:23:58 +0000 http://bbpress.org/?v=1.0.2 q http://forums.leaflabs.com/search.php http://forums.leaflabs.com/topic.php?id=252#post-1928 Fri, 22 Oct 2010 12:23:04 +0000 poslathian 1928@http://forums.leaflabs.com/ <p>yea the _t is a nuisance to me. the "s" is just to signify "signed" to be symmetrical: u16 or s16 ... etc. </p> http://forums.leaflabs.com/topic.php?id=252#post-1898 Thu, 21 Oct 2010 16:32:24 +0000 gbulmer 1898@http://forums.leaflabs.com/ <p>Well, I thought uint8, uint16, uint32, etc. were inspired; they get everyone ready for the transition to Go lang ;-)</p> <p>What is s16 and vu8?</p> <p>When faced with the choice between uint32, u32, uint32_t, and int16, int16_t, i16, ... I'm okay with uint32, int16, etc. Most people recognise them quickly, and it's two characters shorter than the _t versions! </p> http://forums.leaflabs.com/topic.php?id=252#post-1894 Thu, 21 Oct 2010 15:43:12 +0000 poslathian 1894@http://forums.leaflabs.com/ <p>well take a look, thanks! </p> <p>We have definitely had bugs before caused by things like:<br /> #define MY_REG_VALUE 0x12345678</p> <p>which should have been<br /> #define MY_REG_VALUE (uint32)(0x12345678) </p> <p>or using UL notation. Well talk about adding something about this to any coding standards. </p> <p>Personally, I wanted to follow the ST convention of having all the types be as:<br /> u32, u16, s16, vu8, etc - oh well. </p> http://forums.leaflabs.com/topic.php?id=252#post-1835 Mon, 18 Oct 2010 21:15:04 +0000 gbulmer 1835@http://forums.leaflabs.com/ <p>For giggles, I ran splint across maplelib. </p> <p>You might be interested to do the same, just to see the code with 'fresh eyes'.<br /> Sadly splint doesn't seem to handle asm properly :-(</p> <p>There are a couple of things you might want to think about; nothing to worry about, everything I saw were only warnings and appeared to be okay. One thing I'd comment on is using 1UL to get an unsigned 32 bit value. I think both 1U and (unit32)1 work okay and are a bit clearer (to me, anyway). </p>