LeafLabs Garden

A place to share, learn, and grow...

1. 

   x893
   Member

   Current version of libmaple perfectly compiles with arm-none-eabi compiler but not compile with ARMCC. Problem in new features of GCC which not supported with RealView ARMCC. It's not a big changes to make code to comtible with other arm compilers.
   For example

   typedef struct timer_dev {
   timer_reg_map regs; /**< Register map */
   rcc_clk_id clk_id; /**< RCC clock information */
   timer_type type; /**< Timer's type */
   voidFuncPtr handlers[]; /**< User IRQ handlers */
   } timer_dev;

   initialization this structures not support by ARMCC but if you change

   voidFuncPtr handlers[]; /**< User IRQ handlers */
   to
   voidFuncPtr *handlers; /**< User IRQ handlers */

   all OK

   Changes in codes minimal but your code can be used this other system - Keil, IAR and may be other. I check only with Keil and IAR

   Posted 4 years ago #
2. 

   gbulmer
   Moderator

   x893 - Are you sure the two declarations are equivalent? I don't think they are.

   for a struct ending with voidFuncPtr handlers[]; I'd expect to be able to create an instance with arbitrarily many voidFuncPtr handlers, i.e. I'd expect to be able to create an instance of a timer_dev embedding an array of 0 or more voidFuncPtr.

   But I'd expect to create a separate array of voidFuncPtr's pointed at by a voidFuncPtr *handlers;

   I must admit that I am not familiar with the syntax { [NR_ADV_HANDLERS - 1] = 0 } in
   

   static timer_dev timer1 = {
       .regs         = { .adv = TIMER1_BASE },
       .clk_id       = RCC_TIMER1,
       .type         = TIMER_ADVANCED,
       .handlers     = { [NR_ADV_HANDLERS - 1] = 0 },
   };

   I assume the array handlers contains NR_ADV_HANDLERS - 1 voidFuncPtr instances, which is different from a voidFuncPtr *.

   I'd change its name from handlers, maybe to handler_block (or something) so that the compiler would throw an error on every line that needs to be changed.

   I'd expect to create an array for each timer_dev which is referenced by the voidFuncPtr *handler_block; pointer:
   

   static voidFuncPtr _timer1_handlers[NR_ADV_HANDLERS - 1] = { NULL };
   static timer_dev timer1 = {
       .regs         = { .adv = TIMER1_BASE },
       .clk_id       = RCC_TIMER1,
       .type         = TIMER_ADVANCED,
       .handler_block     = _timer1_handlers,
   };

   Posted 4 years ago #
3. 

   x893
   Member

   It's only example. I say about general idea for compatibility. So people can use libmaple not only with GCC and may be expand libmaple as alternative for ST standard library.

   Posted 4 years ago #
4. 

   gbulmer
   Moderator

   x893 - Okay, I think I understand.

   Does voidFuncPtr handlers[0]; work with ARMCC?

   Posted 4 years ago #

RSS feed for this topic

Reply

You must log in to post.