Problem with SPI mode still in master github

(6 posts) (3 voices)

crenn
Moderator

As I mentioned in:

http://forums.leaflabs.com/topic.php?id=121

"EDIT2: SPI mode is always 0. In HardwareSPI.cpp, in function void HardwareSPI::begin, line 105, the line is:
spi_init(spi_num, prescale, endianness, 0);
It should be:
spi_init(spi_num, prescale, endianness, mode);"

I've noticed this hasn't been fixed on github (as far as I can see). Thought I might make another topic to bring it up.

Posted 5 years ago #
perry
Administrator

yup, looks like a bug. if you'd like to submit a patch send me a pull request and i'll commit it. otherwise i'll fix it later tonight.

Posted 5 years ago #
crenn
Moderator

I'm not familiar with using github, need to find a manual for it.

Posted 5 years ago #
mbolivar
LeafLabs

fixed:

http://github.com/leaflabs/libmaple/commit/adde11b099ff5dad176e410279d21feac39d2c7e

Posted 5 years ago #
crenn
Moderator

I saw ;D

Posted 5 years ago #
mbolivar
LeafLabs

ha, cool, just making sure. i'm trying to triage the forums real quick after our maker faire absence.

Posted 5 years ago #

Reply

You must log in to post.