UweBonnes
Member
How to contribute/RFC patches? This forums seems not to allow uploads. A mail address would be preferred. I have to patches pending:
- A small one removing the hard coded values in usart.c for "clk_speed"
- A larger one with (hopefully) all those changes discussed in the STM32 Discovery thread.
The changes are against maple-ide-0.0.9-linux64.tgz. I unpacked in a "git init" directory.
I am not a Leaf Labs employee- but here is my take on how to do this:
1. Create a github account http://github.com
2. Fork the Leaf Labs project you want to contribute to - git hub makes this easy: https://github.com/leaflabs
3. Clone the forked git repository.
4. Make your modifications and commit them to your local repository.
5. Push the changes back to your forked repo on github.
6. Issue a pull request via github and contact Leaf Labs staff via the Forums.
Leaf Labs people, will you improve this?
mbolivar
LeafLabs
Adam,
Yup, github pull requests are ideal. If you're super allergic to git for some reason, I suppose you could email us patches at info@leaflabs.com, but that's a lot less convenient.
Not sure what you mean by "improve this"; I'm extremely impressed with the convenience github has provided thus far.
UweBonnes,
A _lot_ has happened since 0.0.9. All of our development work is currently taking place against the "refactor" branch in the libmaple github repository. Patches to the low-level pure C code will almost certainly not apply. We're grateful for your patches, but would encourage you to work against the current development code if you're going to be contributing patches for the time being.
The refactor branch has a preliminary design document here:
http://static.leaflabs.com/mbolivar/libmaple_design/
In particular, the hard-coded clk_speed (along with the rest of usart.h and usart.c) have been largely rewritten to be more general. I have yet to push those changes (they're in my local clone), but am hoping to get them in by the end of the week.
mbolivar
LeafLabs
Adam,
Sorry if I came off brusque in my previous, no offense was meant.
It does make sense to formalize the patch submission procedure. I've added an FAQ about it to the libmaple design doc; it'll get incorporated (in some form) into the next release:
http://static.leaflabs.com/mbolivar/libmaple_design/faq.html#how-can-i-help-commit-patches
Update: making this topic sticky until the official docs include this information.
You must log in to post.
