http://forums.leaflabs.com/topic.php?id=9937 A place to share, learn, and grow... en-US Fri, 22 Jan 2016 00:21:37 +0000 http://bbpress.org/?v=1.0.2 q http://forums.leaflabs.com/search.php http://forums.leaflabs.com/topic.php?id=9937#post-21746 Thu, 20 Dec 2012 11:46:58 +0000 jake1981 21746@http://forums.leaflabs.com/ <p>Updates made - I also updated all my other libraries. Now licenses are mentioned. </p> http://forums.leaflabs.com/topic.php?id=9937#post-21737 Thu, 20 Dec 2012 00:20:15 +0000 jake1981 21737@http://forums.leaflabs.com/ <p>I'll update the library when I've got some time. But let's get to the answers;</p> <p>What is my work based on? It is not based on that source, it's based on some other<br /> source that I unfortunately cannot remember Where it located on the internet - but I chose<br /> That one Because it was more informative than arduino pirsense doc. If I remember correctly,<br /> It was on instructables.com</p> <p>My license will be updated to readme. It will be public domain.</p> <p>Yes, the device I used was the cheapest parallax type sensor I found from the ebay. Same sensors are sold also at electrodragon.com</p> <p>Idea in my library is to record if there has been movement, that's why I wrote it that way, as project I plan to use this doesn't necessarily need the value all the time, but on a request; it needs to know if there has been activity..</p> <p>And sorry about that digitalwrite low, I haven't readed all the docs and thought it couln't hurt. I'll add a ifdef arduino to that code.. </p> http://forums.leaflabs.com/topic.php?id=9937#post-21733 Wed, 19 Dec 2012 16:56:57 +0000 jake1981 21733@http://forums.leaflabs.com/ <p>Thanks. Don't know if it speeds up a anything, but shorter source is always good.. I'll fix this later.. </p> http://forums.leaflabs.com/topic.php?id=9937#post-21728 Wed, 19 Dec 2012 10:50:55 +0000 gbulmer 21728@http://forums.leaflabs.com/ <p>jake1981 - I had a quick look at your library. </p> <p>IMHO it is good form to acknowledge the authors work that is used as a basis for new work.<br /> I assume it is <a href="http://playground.arduino.cc/Code/PIRsense" rel="nofollow">http://playground.arduino.cc/Code/PIRsense</a><br /> IMHO you should also say what the copyright status of the code is.</p> <p>I think it would be helpful for you to say which PIR sensor you have tested the code with. It looks like you might used something like the Parallax PIR sensor (e.g. at <a href="http://www.parallax.com/tabid/768/txtSearch/PIR+sensor/List/0/SortField/4/Default.aspx)" rel="nofollow">http://www.parallax.com/tabid/768/txtSearch/PIR+sensor/List/0/SortField/4/Default.aspx)</a></p> <p>Those are different from a 'raw' PIR sensor, (e.g. <a href="http://uk.farnell.com/murata/ira-e712st3/pir-high-light-immunity/dp/1006207)" rel="nofollow">http://uk.farnell.com/murata/ira-e712st3/pir-high-light-immunity/dp/1006207)</a> which need a signal amplifier. So being clear is helpful.</p> <p>How thoroughly do you understand the original code?<br /> I ask because the code:<br /> <pre><code>PIR::PIR(uint8 pin) { _pin = pin; pinMode(_pin, INPUT); digitalWrite(_pin, LOW); // ...</code></pre> <p>makes sense on an Arduino, but is a odd for an STM32. </p> <p>The statement <code>pinMode(_pin, INPUT);</code> sets the pin to be an input.<br /> So the statement <code>digitalWrite(_pin, LOW);</code> is strange, without an explanation, because normally code wouldn't write to an input pin.</p> <p>However, on an Arduino (ATmega168/328), that sequence ensures the I/O ports pull-up resistor for that pin is off.<br /> On Maple that <code>pinMode(_pin, INPUT);</code> is sufficient, or you could say <code>pinMode(_pin, INPUT_FLOATING);</code> (which is the same) if you wanted to be explicit about the pull-up/pull-down resistors.</p> <p>IMHO the logic of the PIR class is unnecessarily complicated.<br /> It might be simpler to either have:<br /> a) a function which blocks until the sensor calibration time has passed (probably not ideal as the Parallax data sheet says this could be 60 seconds, but workable), or<br /> b) a function which itself returns true once the calibration time for the PIR has elapsed. For example, set the variable calibrationTime = millis() + actual calibration time in the constructor, then put the first-time calibration logic in a renamed<code>calibrating</code> (is_calibrated?), and there is no need to call <code>updating</code>. Just ask for the state of the PIR pin.</p> <p>It also isn't clear that the concept of waiting for a period of time is completely implemented in the PIR. It seems to be divided between the demo program and the PIR class. If the _state variable, and all methods that use it are removed from the PIR class, then the PIR class becomes simpler, and the demo program seems simple too. Or move all the logic into the PIR class, and have it solve that part f the use case.</p> <p>A small point. Code like this:<br /> <pre><code>boolean PIR::calibrating(void) { if ( calibrationTime == 0 ) return false; return true; }</code></pre> <p>May be simpler as:<br /> <pre><code>boolean PIR::calibrating(void) { return (calibrationTime != 0); }</code></pre> <p>Just my $0.02. HTH </p> http://forums.leaflabs.com/topic.php?id=9937#post-21715 Tue, 18 Dec 2012 17:11:45 +0000 jake1981 21715@http://forums.leaflabs.com/ <p>Hi. Again.</p> <p>I have written a simple PIR library for Maple. Handling PIRs is easy, with this library.. It is even easier..<br /> Check the example for usage..</p> <p><a href="https://github.com/oskarirauta/PIR_sensor_library" rel="nofollow">https://github.com/oskarirauta/PIR_sensor_library</a> </p>